Settings

Theme

Write broken commits for better review

huonw.github.io

2 points by dbaupp 2 months ago · 2 comments

Reader

gus_massa 2 months ago

> The common thread through these is that we’re building a PR that involves some mechanical changes and some ‘real’ ones. Separating them at the commit level, even if invalid, makes both types of changes easier to understand

My recommendation is to keep the commit separated, but go and rewrite the history of the branch to get all intermediate commits compiling. It's painful, but it help the reviewer checking what happened.

turtleyacht 2 months ago

Broken commits are useful as proof you already tried something that didn't work.

Keyboard Shortcuts

j
Next item
k
Previous item
o / Enter
Open selected item
?
Show this help
Esc
Close modal / clear selection