Settings

Theme

Looking Back on Phabricator for Code Review

davidgomes.com

23 points by davidgomes 25 days ago · 3 comments

Reader

starkparker 25 days ago

I loved Phabricator and hadn't heard about Phorge. Co-signed on all of these points.

tveita 25 days ago

> In GitHub, you have to switch tabs (which is slow and distracting) to go between the PR summary and the code.

As a case study of Github UI friction, take merging a Dependabot PR from the PRs tab, with code approval required before merges. By my count this takes 6 clicks, and none of them approach a 'snappy' response time.

This is for mostly trivial single-line diffs. The entire thing could be 1 click - a hover preview on the PR list, and an 'approve and merge' button.

(To list them out: Click PR, "Files changed", "Submit review", "Approve", "Submit Review", "Merge")

chriscbr 24 days ago

Does Facebook/Meta still use Phabricator or Phorge directly? Or do they use a fork of one of them internally?

Keyboard Shortcuts

j
Next item
k
Previous item
o / Enter
Open selected item
?
Show this help
Esc
Close modal / clear selection