Settings

Theme

Why your pull request might not be merged

00f.net

2 points by vishnumohandas 7 months ago · 2 comments

Reader

MultifokalHirn 7 months ago

I agree - if you are going to invest non-negligible time and effort into submitting a pull request on somebody else's project, ask whether your change is wanted.

  • gus_massa 7 months ago

    I prefer the "don't waste more than 2 days writing the pull request" approach, only a mythical weekend, not hard feelings if it's not merged.

    For me, in short PR it's easier to explain "I want to modify foo so it also does bar" with a pull request than in plain English.

    If you are going to take a month to write a PR with a few hundreds of LOC changes, then I agree that it's better to ask the maintainer first.

Keyboard Shortcuts

j
Next item
k
Previous item
o / Enter
Open selected item
?
Show this help
Esc
Close modal / clear selection