Settings

Theme

Ask HN: How many code reviewers should you require?

2 points by dukerutledge 3 years ago · 5 comments


idlephysicist 3 years ago

Two sets of eyes is ideal.

Making use of things like GitHub CODEOWNERS files can be very useful too, allowing for certain directories to require reviews from certain individuals or user groups. For example, a directory containing the Helm Chart for a service might require a review from someone in the infrastructure team.

crop_rotation 3 years ago

Keep the entire team as optional but most reviews can be done by 1 or max 2 people.

yobid20 3 years ago

0. I commit and push directly to master.

akerl_ 3 years ago

It depends.

alex_lav 3 years ago

0-2.

More than 2 is unnecessary.

Keyboard Shortcuts

j
Next item
k
Previous item
o / Enter
Open selected item
?
Show this help
Esc
Close modal / clear selection