Settings

Theme

Ask HN: What makes a good code review?

2 points by jzymbaluk 3 years ago · 2 comments · 1 min read


My team at work is trying to formalize and iterate on our processes, and one process that currently is very much not nailed down is the code/pull request review.

What in your experience makes a good and valuable or bad code review? One that is valuable for the codebase, developer and reviewer?

jschveibinz 3 years ago

Here is a good resource:

https://smartbear.com/learn/code-review/what-is-code-review/

Keyboard Shortcuts

j
Next item
k
Previous item
o / Enter
Open selected item
?
Show this help
Esc
Close modal / clear selection