Ask HN: What does code review look like in your team?
I lead a small team building web apps, but we currently have very little structure around code review. I want to get the right balance of process and tooling, but it would be interesting to learn what a healthy code review process looks like in other teams/orgs.
So, what works well for your team? (And what doesn't?)
Do you run the code that you are reviewing? Is it deployed somewhere automatically (if relevant)?
For change requests or bug reports, do you share repro steps? What does this look like? Screenshots, videos, something else?
Is there any sort of acceptance testing before code is merged?
I'm wondering how much process is helpful and ensures quality before it becomes onerous. I try to do code review religiously, and comment on structure, direction, and people committing the worst of all sins, mixing dashes and underscores in a single name. One of my coworkers logs in once a day and approves everything. Most of the team never does any code review.