Conversation
Fixes #19918
Adds a simple option under the Customise menu which disables completely the home button from the toolbar.
19918.mp4
Pull Request checklist
- Tests: N/A - let me know if any tests are required
- Screenshots: Video included
- Accessibility: Checked the additional menu entry with Accessibility scanner
To download an APK when reviewing a PR:
- click on Show All Checks,
- click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
- click on the "Fenix - assemble" task, then click "Run Artifacts".
- the APK links should be on the left side of the screen, named for each CPU architecture
No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the default branch) does not allow starting tasks for this pull request.
@tasosb Thanks for the patch. I am checking with Product/UX regarding this feature request, but we might not be able to immediate accept pending their decision. Sorry for any inconvenience.
Are they all on vacation? This is low-hanging fruit, folks
Are they all on vacation? This is low-hanging fruit, folks
I didn't intend for this to come across disrespectful, it just that this one seems like such a quick and simple thing and a LOT of users have been asking for this option. Please if you can just take out a few minutes to approve it, it would be a nice little holiday gift for Fenix users :)
This pull request has conflicts when rebasing. Could you fix it @tasosb? 🙏
@gabrielluong Whenever product gives the green light, ping me and I will fix any conflicts.
@gabrielluong Whenever product gives the green light, ping me and I will fix any conflicts.
Apologizes for the inconvenience, I did reach out to product a week ago, and I am still expecting them to be the ones to respond when they make a decision.
Thank you for submitting the patch and apologies for the delay in reply. Can you please provide more detail about the issue you're experiencing with the home button and why you'd like the option to disable it? This will help me to determine if we should support the option moving forward
Thank you for submitting the patch and apologies for the delay in reply. Can you please provide more detail about the issue you're experiencing with the home button and why you'd like the option to disable it? This will help me to determine if we should support the option moving forward
Please read through the issue... #19918
@athomasmoz Thanks for looking into this PR!
Basically, it is about having a clearer toolbar and seeing more of the URL. Surely some people like the home button and some others like having a more minimal toolbar (we can view the home screen if needed by opening a new tab).
As @willfs84 wrote, you can see all of the discussion (and votes) regarding this issue/PR on issue #19918
Yes and also, when you tap the address bar, the home page sort of overlays on top of the website (the on screen keyboard remains open). So I don't really understand why this home button was added... You can simply tap the address bar and it's the same thing...
Thank you for providing the extra detail. I think this is one we should tackle, but it will need a review on the setting name & to be localized. Adding appropriate tags
Any further updates on this?
I also need this PR to be applied ASAP, I am using a Moto G6 plus and although the screen is decent the UI clutter is noticeable
Any further updates on this?
I received word that it's currently assigned on the UX board right now.
Yes and also, when you tap the address bar, the home page sort of overlays on top of the website (the on screen keyboard remains open). So I don't really understand why this home button was added... You can simply tap the address bar and it's the same thing...
Exactly. Currently the only difference between tapping the home button and tapping the address bar is that the keyboard opens for the latter. All home page buttons are available for both cases. Don't see the need to clutter the urlbar.
This pull request has conflicts when rebasing. Could you fix it @tasosb? 🙏
Any news? I love Firefox but the home button taking space is still a problem
I'm really surprised by how long this is taking considering how trivial and straightforward it is. Can someone please at least tell us what the hold up is?
Hello @gabrielluong,
Is there any update on the internal ticket with the UX team? Because from what I understand the PR's concept is already approved but this is waiting 2 months just for the setting name.
Hello @gabrielluong, Is there any update on the internal ticket with the UX team? Because from what I understand the PR's concept is already approved but this is waiting 2 months just for the setting name.
Checking.
Circling back. I see it on UX's TODO and assigned. It's not in the current sprint, but should be in the upcoming sprint. I will keep watching, but my estimate is that we will get this in either for version 100 (this month) or 101 (or next).
After further discussion and consideration for the overall experience, I'm going to close this as won't fix. The homepage on Firefox has been a focus area for us and has become a hub for finding content you have previously visited and saved. We plan to continue enhancing the homepage in the future and want to ensure it's easy for everyone to access through this toolbar button.
After further discussion and consideration for the overall experience, I'm going to close this as won't fix. The homepage on Firefox has been a focus area for us and has become a hub for finding content you have previously visited and saved. We plan to continue enhancing the homepage in the future and want to ensure it's easy for everyone to access through this toolbar button.
The homepage can be accessed by clicking on the adress bar and by opening a new tab.
Removing this button doesn't remove acceess to the homepage at all.
On desktop, homepage is primarily accessed by opening a new tab.
I really don't get your argument.
Url is key while browsing, the shield and padlock has been merged with the only goal to increase url size a while ago. Few month later this icon has been added. It looked like a step backward.
After further discussion and consideration for the overall experience, I'm going to close this as won't fix. The homepage on Firefox has been a focus area for us and has become a hub for finding content you have previously visited and saved. We plan to continue enhancing the homepage in the future and want to ensure it's easy for everyone to access through this toolbar button.
How out of touch is the UI/UX team lol. The home button and the URL bar do the same thing. One tip for effective UI/UX: reduce redundancy.
After further discussion and consideration for the overall experience, I'm going to close this as won't fix. The homepage on Firefox has been a focus area for us and has become a hub for finding content you have previously visited and saved. We plan to continue enhancing the homepage in the future and want to ensure it's easy for everyone to access through this toolbar button.
Ok man... I will stop using my favorite browser, if you are okay with two buttons that do the same I will not support it because it tells me you are okay bloating user interfaces, as an UX lover it tells me you do not care about it
@athomasmoz Please listen to the community. This is still a painful issue for me, as I keep accidentally tapping the home button with edge of my finger. I am trying to switch to Firefox nightly from kiwi/chromium browser. Now that Firefox supports extensions on android, there is no reason for me to stay on chromium.
After further discussion and consideration for the overall experience, I'm going to close this as won't fix. The homepage on Firefox has been a focus area for us and has become a hub for finding content you have previously visited and saved. We plan to continue enhancing the homepage in the future and want to ensure it's easy for everyone to access through this toolbar button.
Ok man... I will stop using my favorite browser, if you are okay with two buttons that do the same I will not support it because it tells me you are okay bloating user interfaces, as an UX lover it tells me you do not care about it
Sorry if I ended sounding harsh, sometimes that happens to me when people dismiss the community and the people who care the most for a good quality UX
Come to think about you actually have 3 new tab buttons! The "home" button, new tab in the menu overflow and the one tab switcher, there is no need for such redundancy
I do not like gating stuff but... Why not AT LEAST you add a string in the about:config to remove th unnecesary items? That way you could still give the average user your intended UX and us who can use advanced tools like GitHub could still set that parameter in the Firefox nightly about:config? It is NOT the best solution but it is something
@athomasmoz Please listen to the community. This is still a painful issue for me, as I keep accidentally tapping the home button with edge of my finger. I am trying to switch to Firefox nightly from kiwi/chromium browser. Now that Firefox supports extensions on android, there is no reason for me to stay on chromium.
TBH that is why I wish this issue was solved and not dismissed