New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14995
📔 Objective
- A user with premium should not be able to use TOTP codes on items held by a non premium organization.
⏰ Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation or informed the documentation team
🦮 Reviewer guidelines
- 👍 (
:+1:) or similar for great changes - 📝 (
:memo:) or ℹ️ (:information_source:) for notes or general info - ❓ (
:question:) for questions - 🤔 (
:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion - 🎨 (
:art:) for suggestions / improvements - ❌ (
:x:) or⚠️ (:warning:) for more significant problems or concerns needing attention - 🌱 (
:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt - ⛏ (
:pick:) for minor or nitpick changes
| .value | ||
| ?.activeAccount | ||
| ?.getOrganizationPremiumStatusMap() | ||
| ?: emptyMap() |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just do orEmpty()
| val organizationOwnedTotpItems = totpItemsGroupedByOwnership[true] | ||
| ?.filter { | ||
| it.login?.totp != null && | ||
| (organizationPremiumStatusMap[it.id] == true || it.organizationUseTotp) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting here
| it.login?.totp != null && | ||
| (organizationPremiumStatusMap[it.id] == true || it.organizationUseTotp) | ||
| } | ||
| ?: emptyList() |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do more orEmpty()s
This feature is in direct violation to the outline of your user agreements and feature list.
"Storage of keys is available to all accounts, however TOTP code generation requires Premium or membership to a paid organization (Families, Teams, or Enterprise)." https://bitwarden.com/help/integrated-authenticator/
OR not AND
dseverns-livefront added a commit that referenced this pull request
