This is enough for pkgsCross.x86_64-cygwin.hello to build.
Things done
- Built on platform:
- x86_64-linux
- aarch64-linux
- x86_64-darwin
- aarch64-darwin
- Tested, as applicable:
- NixOS tests in nixos/tests.
- Package tests at
passthru.tests. - Tests in lib/tests or pkgs/test for functions and "core" functionality.
- Ran
nixpkgs-reviewon this PR. See nixpkgs-review usage. - Tested basic functionality of all binary files, usually in
./result/bin/. - Nixpkgs Release Notes
- Package update: when the change is major or breaking.
- NixOS Release Notes
- Module addition: when adding a new NixOS module.
- Module update: when the change is significant.
- Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.
Add a 👍 reaction to pull requests you find important.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 444470
Commit: 84360d8b5b525c8f3272ed0cbde65c3d48c8d9dc
x86_64-linux
⏩ 2 packages blacklisted:
- nixos-install-tools
- tests.nixos-functions.nixos-test
✅ 2 packages built:
- cocom-tool-set
- nixpkgs-manual
corngood marked this pull request as ready for review
Cygwin cross
cygwin: add as a cross-compilation target, and get nix to build
Co-authored-by: Brian McKenna <brian@brianmckenna.org>
Co-authored-by: Brian McKenna <brian@brianmckenna.org>
There are a lot of threads in here, and I think I've responded to all of them, but I didn't resolve them unless there was a clear conclusion. Does anyone have any more blocking feedback (especially those with open reviews: @roberth @Ericson2314)?
I want to see this happen ASAP, but I am going to let @alyssais do final approval, unless she delegates to someone else.
Woo so excited!! (That's why I cannot be the final approval, I'm too compromised in my excitement :))