| author | Lexi Winter <ivy@FreeBSD.org> | 2026-01-03 01:13:22 +0000 |
|---|---|---|
| committer | Lexi Winter <ivy@FreeBSD.org> | 2026-01-03 02:57:16 +0000 |
| commit | 2e92aeede85c8986bd6f4dde65d2ac2449eccf51 (patch) | |
| tree | c7a3d079138fcad2162cf6c17e86fcbac4658149 | |
| parent | 3e6e4e4a0d42fa24f3b2a1c087e9ad25f9594081 (diff) | |
bridge: Allow BRDGSIFVLANSET without IFBRF_VLANFILTERHEADmain
Currently, we disallow BRDGSIFVLANSET when IFBRF_VLANFILTER is disabled. There's no particular reason to do this, and it causes some undesirable behaviour such as not being able to remove the tagged config on a member after disabling vlanfilter on the bridge. Remove the restriction so BRDGSIFVLANSET is always accepted. PR: 292019 MFC after: 1 week Reviewed by: zlei, p.mousavizadeh_protonmail.com Sponsored by: https://www.patreon.com/bsdivy Differential Revision: https://reviews.freebsd.org/D54435
| -rw-r--r-- | sys/net/if_bridge.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/sys/net/if_bridge.c b/sys/net/if_bridge.c
index 9a468a8eb462..5bdd8613245e 100644
--- a/sys/net/if_bridge.c
+++ b/sys/net/if_bridge.c
@@ -1990,9 +1990,6 @@ bridge_ioctl_sifvlanset(struct bridge_softc *sc, void *arg)
struct ifbif_vlan_req *req = arg;
struct bridge_iflist *bif;
- if ((sc->sc_flags & IFBRF_VLANFILTER) == 0)
- return (EXTERROR(EINVAL, "VLAN filtering not enabled"));
-
bif = bridge_lookup_member(sc, req->bv_ifname);
if (bif == NULL)
return (EXTERROR(ENOENT, "Interface is not a bridge member"));