I Found a Bug in Apple's Fsck_hfs

I believe I potentially wrote that code in 2006 when working at Apple on HFS. What a remarkable world!

I would consider HFS+ to be a legacy filesystem at this point, something you shouldn't use without a really good reason (interop with pre-macOS 10.13 machines being the only one I can think of).

Fun fact: HFS dates back to the 80s, and so does the fsck code. https://github.com/apple-oss-distributions/hfs/blob/main/lib... still contains '#if BSD' blocks for the Mac OS X code, and classic Mac code in the '#else'.

And 'dfalib' refers to 'Disk First Aid', the classic Mac fsck application.

Note to the author: did you file an Apple feedback for this? You should put that FB number in your post and the GitHub repo, it will ease the process for any Apple employees who see this and want to get it fixed.