Settings

Theme

Redefining Go Functions

pboyd.io

38 points by todsacerdoti 3 hours ago · 13 comments

Reader

nasretdinov 28 minutes ago

I've used a different approach to this: there's no real need to modify the compiled binary code because Go compiles everything from source, so you can patch the functions at the source level instead: https://github.com/YuriyNasretdinov/golang-soft-mocks

The way it works is that at the start of every function it adds an if statement that atomically checks whether or not the function has been intercepted, and if it did, then executes the replacement function instead.

My tool no longer works since it was rewriting GOPATH, and Go since effectively switched to Go Modules, but if you're persistent enough you can make it work with Go modules too — all you need to do is rewrite the Go module cache instead of GOPATH and you're good to go.

MadVikingGod 2 hours ago

This is all possible and quite neat to dive into the specifics, but if you really want to be able swap a std lib call, just turn it into a variable and change it.

  // code.go
  var now = time.Now

  // code_test.go
  func TestCode(t *testing.T) {
      nowSwap := now
      t.Cleanup (func() {
          now = nowSwap
      }
      now = func() time.Time {
          return time.Date(...)
      }
  }

Examples Code: https://github.com/open-telemetry/opentelemetry-go/blob/main... Test: https://github.com/open-telemetry/opentelemetry-go/blob/490f...
  • matttproud 15 minutes ago
  • metadat 37 minutes ago

    That is a useful pattern, though I was unclear on why `t.Cleanup` and not `defer`. In case others are curious, too:

    > Parallel subtestsWith t.Run(..., func(t testing.T) { t.Parallel(); ... }), the parent test function can return (and thus run its defers) before parallel subtests actually finish.*

  • antonvs an hour ago

    The point of the OP is that it changes calls to `time.Now` regardless of whether the code that's calling it uses your variable or not.

    • Groxx 43 minutes ago

      I suspect that using a build tag (say `test`) and two function definitions (one that directly calls `time.Now()` and one test-only one that uses a mutable var) will optimize out to zero cost in the non-test case - last I fiddled with that, it was pretty good at consistently inlining trivial wrapper funcs like that.

jerf 2 hours ago

Other prior art: https://github.com/bouk/monkey with accompanying blog post https://bou.ke/blog/monkey-patching-in-go/

pstuart 2 hours ago

Yikes, I don't see any legitimate use for this, other than hacking for the sake of hacking. Interesting read though.

  • lokar 19 minutes ago

    I’ve seen this in large C++ systems to allow for a runtime patch, generally to add a simple debug call at the start of a function.

  • maccard 2 hours ago

    Hot reloading for development loops is _the_ canonical use case for this.

  • antonvs an hour ago

    wdym, now it will be possible to implement Wordpress in Go

    • pjmlp 29 minutes ago

      You could already do that today, via OS IPC mechanisms, at the expense of higher systems resources, with each plugin being its own process.

  • throwa356262 an hour ago

    Well, we are on Hacker News after all...

Keyboard Shortcuts

j
Next item
k
Previous item
o / Enter
Open selected item
?
Show this help
Esc
Close modal / clear selection