Settings

Theme

Two open source projects with great architecture documentation

johnjago.com

378 points by johnjago 2 years ago · 37 comments

Reader

lioeters 2 years ago

Well-written article with examples, screenshots, going into the specifics of what makes a project documentation great for users/developers/contributors.

It made me reflect on my own work and side projects, how I could improve the docs to make things easier to understand for myself and others. As I've grown as a developer, I've been writing more and more documentation, same with tests, to a point where some projects have more tests and docs than the actual code itself.

I've heard it said that writing good documentation requires a different set of skills than writing code. Sometimes a person who is not technical or focused on development can be better at explaining things. At the least it requires a different perspective, to target the human runtime.

I'll also add that automatically generated docs can be very useful, not by themselves only, but as an additional reference.

eliasson 2 years ago

Antirez (redis creator) has written a good post [1] detailing his thoughts on code comments where he identifies nine type of comments used in Redis.

What surprised me was the use of "guide comments" which most people dismiss as too trivial. I agree with Antirez conclusion that they are valuable to help the reader acknowledge their understanding of the code.

[1] http://antirez.com/news/124

  • godshatter 2 years ago

    I like guide comments because they show intent and because if you're scanning a function in an editor where comments stand out visually then it gives you a quick recipe of what the function nominally should be doing, which helps when you're trying to come up to speed in a code base.

    They are even more useful if the author hates whitespace and tries to be too clever. I spend a lot of time trying to figure out code someone else wrote and appreciate anything that can set me in the right direction when trying to figure out what a particular function does.

  • tacone 2 years ago

    The Laravel source code is an impressive example of that.

ysleepy 2 years ago

Reminds me of the "The Architecture of Open Source Applications" series.

It has some interesting insights.

https://aosabook.org/en/

gurjeet 2 years ago

Postgres project also pays great attention to detail when it comes to documentation, readme files, and code comments.

johnjagoOP 2 years ago

I was particularly impressed by the first one, esbuild. The architecture documentation is so thorough—it’s something I would have loved to have for codebases I’ve worked on in the past.

Does anyone have other examples of projects with this level of architecture documentation?

  • chubot 2 years ago

    I wonder if the diagrams were done in Figma? Diagrams are probably the #1 thing missing from most docs, and they are hard / time-consuming to make

    They do look very nice

    The author of esbuild was also the CTO/main author of Figma, as far as I understand

xbar 2 years ago

"The biggest deficiency in the free software community today is not in the software—it is the lack of good free documentation that we can include with the free software."

- gdb manual

  • mjw1007 2 years ago

    When was "today" when that was written?

    • hn_acker 2 years ago

      The gdb manual might have been quoting the essay "Why Free Software Needs Free Documentation" [1] written in 1996 [2] by someone (not confirmed to be Richard Stallman AFAICT) at the Free Software Foundation. Excerpt [1]:

      > The biggest deficiency in free operating systems is not in the software—it is the lack of good free manuals that we can include in these systems. Many of our most important programs do not come with full manuals. Documentation is an essential part of any software package; when an important free software package does not come with a free manual, that is a major gap. We have many such gaps today.

      [1] https://www.gnu.org/philosophy/free-doc.html

      [2] https://www.gnu.org/philosophy/essays-and-articles.html

lnxg33k1 2 years ago

To stay around the topic I really love majority of changelogs of open source projects, they're great, much more professional and informative than other for-profit entities, just this week I had to offend those clowns at ING bank because despite handling people's money, would try to be funny in app changelogs instead of being informative

hn_acker 2 years ago

As footnote 1 in the featured article mentions, Redis is not open source anymore. From Redis [1]:

> Redis is source-available software, available under both the Redis Source Available License v2 (RSALv2) and the Server Side Public License v1 (SSPLv1).

> Redis Stack and all Redis modules created by Redis Ltd. (e.g., RediSearch, RedisJSON, RedisGraph, RedisTimeSeries, and RedisBloom) are dual-licensed under the Redis Source Available License v2 (RSALv2) and SSPL.

> Redis Enterprise is closed source and requires a commercial license from Redis Ltd.

There are previous versions of Redis under the 3-clause BSD license (free and open source [2]) [1]:

> Can I continue to use versions of the products that were provided under the original 3-clause BSD license?

> Yes. The license change is not retroactive. This means all source code and releases prior to the change remain under the 3-clause BSD license. You may continue to use those versions indefinitely under the original license, as long as you abide by its terms and conditions.

[1] https://redis.com/legal/licenses/

[2] https://en.wikipedia.org/wiki/BSD_licenses#3-clause_license_...

SebFender 2 years ago

Documenting projects and situations in general is so underrated. Don't need to go overboard, but a good foundation for understanding streamlines so many things in the end. Good read.

raybb 2 years ago

I feel like GitLab's docs have a reputation for being very good but I haven't had much need to use them myself. Would you consider their architecture docs good?

  • pratclot 2 years ago

    Ehm, their docs are an example of a case when stackoverflow answers provide better docs than the official pages. To put it politely.

noahbald 2 years ago

I have a repo [1] on awesome architecture docs if anyone wants more examples. It should be copied over to here [2] soon, too.

[1] https://github.com/noahbald/awesome-architecture-md [2] https://github.com/matiassingers/awesome-readme

lukaszkups 2 years ago

Another example of great documentation is Vue.js one [1].

[1] https://vuejs.org/

pbnjay 2 years ago

As a counterpoint/opportunity… what are some great open source projects (e.g well-used/adopted) that do NOT have great docs?

  • spit2wind 2 years ago

    Guile Scheme: https://www.gnu.org/software/guile/manual/html_node/index.ht...

    It looks like it should be good. There is a lot written. However, it's extremely disjointed and unfairlt assumes readers know things. It uses terms not defined yet, or even at all. As a taste, assume you are new to lisp and scheme. Try reading the Chapter 3: Hello Scheme![1] It contains so much mind bogglingly useless information presented in the most obtuse way possible.

    Okay, you might say, that's the Reference Manual, not the Tutorial[2]. The tutorial is better...except it literally doesn't explain how to run the code. Instead, it tells you to not only to get Emacs, but to also configure it with Geiser. It doesn't show you how to do that. It passes you off to other manuals. Or, to set up Dr. Racket. To be clear, running guile code is as simple as typing 'guile' which starts the interpreter.

    It's very common for the documentation to hand wave away major ideas by linking elsewhere and assuming that the linked references actually explain things (they rarely do).

    Anyway, I could go on. It's simply the worst documentation I've seen because it continually leads you to believe it's good. Yet, it rarely delivers the information you need.

    [1] https://www.gnu.org/software/guile/manual/html_node/Hello-Sc...

    [2] https://spritely.institute/static/papers/scheme-primer.html

  • unclad5968 2 years ago

    SDL2 docs are not amazing, but the project itself is an incredible achievement of cross platform development.

    • iainmerrick 2 years ago

      Agreed to both.

      That brings Three.js to mind, that's another terrific project with patchwork docs.

    • ndiddy 2 years ago

      The bespoke SDL docs aren’t too good but the header files have great documentation.

  • iainmerrick 2 years ago

    React, especially React Native.

    There are lots of docs, and in most cases the quality at some point was good, but they're often out of date, and old versions hang around for a long time. Real world projects often use wildly different versions of React (because it's hard to keep up with the version churn) so I guess all those different doc versions are necessary.

    For React Native, the docs are missing detail so you have to look at the code, and the code comments were pretty spotty and inconsistent the last time I looked.

  • allarm 2 years ago

    Ansible documentation is nightmarish.

  • n_plus_1_acc 2 years ago

    Gradle for sure

tamimio 2 years ago

NixOS and ArchOS are also the first that come to my mind, I remember also there was a less known open source project and have an amazing documentation to the point I tagged it “great docs” or something, but I lost my “my pocket” bookmarks years ago and can’t remember what was the project.

janpmz 2 years ago

This shows that the maintainers really care about the quality of their repository.

tison 2 years ago

Thanks for your sharing.

I was ever working actively on Apache Kvrocks, an alternative for Redis on Flash. And we benefit a lot from Redis docs to catch up its command. In comparison, Kvrocks docs is clearly "less than awesome".

In my $DAYJOB, I convince my boss that the docs, at least the README is important, as you show the esbuild example here.

Here are two patches to improve the README of it:

* https://github.com/GreptimeTeam/greptimedb/pull/3528

* https://github.com/GreptimeTeam/greptimedb/pull/3522

That in #3522 firstly, I tried to reduce the content and "offload" the detailed docs into the doc site. And in #3528, I found that heading elements center align is still fancy and we need some short, clear introduction and advantages.

Anyway, a good product is the leading 1 and docs is the following 0. Without a good product, no good docs can be present.

Keyboard Shortcuts

j
Next item
k
Previous item
o / Enter
Open selected item
?
Show this help
Esc
Close modal / clear selection