Settings

Theme

The comprehensive guide to writing the best PR title of all time

graphite.dev

40 points by kdottt 2 years ago · 10 comments

Reader

karagenit 2 years ago

Definitely some interesting results, though I wish they went into a little more detail on their methodology. For example, is lower case better because it’s harder to read Titles With Every Word Capitalized? Or is it because PR titles in ALL CAPS tend to get ignored for being annoying which biases the results against capital letters?

Also I don’t buy their time saving numbers at the end. According to their own numbers the average dev spends 1.34 * 590 = 791 days per year waiting on review?? At least at my company I’ve never had to sit and wait around for a review, even if thr PR is blocking some other work there’s always been unrelated stories to do instead.

  • hackermailman 2 years ago

    Yes in your company where people are paid they will review in a reasonable time but everyone else who's tried a pr to an open source project they sit there for months unless trivial to review.

grrowl 2 years ago

Article is really just data from their service, and gets it a bit inside-out. Anecdotally, PRs with "!" in the title are often actionable and mergeable, with reviewers pre-involved and ready to merge because of the content, not for the title.

l0b0 2 years ago

Cue people optimising for this rather than using grammar, punctuation, and capitalisation properly. :(

Ecoste 2 years ago

ok!! this is quickly! surprising!! "The average professional engineer (more than 200 PRs a year) authors nearly 600 PRs a year (590) with a median time to review of 1.34 days."

are they! just! typing! the whole!! day!!

kushxg 2 years ago

all of my PRs will now be titled `fix: making! a! great! change!`

Keyboard Shortcuts

j
Next item
k
Previous item
o / Enter
Open selected item
?
Show this help
Esc
Close modal / clear selection